Fix test @freeze_time date values#52
Merged
ykitamura-mdsol merged 3 commits intomainfrom Jan 17, 2025
Merged
Conversation
It was being masked in the constructor as the result of the method call was being assigned to a property also named request_attributes.
This fixes an issue with the time set by @freeze_time being different than the expected EPOCH value.
This fixes an issue with the time set by @freeze_time being different than the original test case request time.
ejinotti-mdsol
approved these changes
Jan 16, 2025
Contributor
ejinotti-mdsol
left a comment
ejinotti-mdsol
left a comment
There was a problem hiding this comment.
nah, definitely no changelog as this is just test code so not even bumping the package version
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a small fix to some of the tests to make the date passed to
@freeze_timematch the value expected by the tests. Before the datetimes were being created as naive datetimes and would use the local timezone instead of UTC. This change makes it so the tests don't also have to pass in the time as an override attribute to theSignermethods being tested.I wasn't sure if this merited a changelog entry, but am happy to add one if need be.